Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Fri, 18 Aug 2017 04:38:00 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13095509.1503018377000.61565.1503031080118@Atlassian.JIRA>
In-Reply-To: <JIRA.13095509.1503018377000@Atlassian.JIRA>
References: <JIRA.13095509.1503018377000@Atlassian.JIRA> <JIRA.13095509.1503018377491@jira-lw-us.apache.org>
Subject: [jira] [Commented] (PHOENIX-4099) Do not write table data again
 when replaying mutations for partial index rebuild
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 18 Aug 2017 04:38:06 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131707#comment-16131707 ] 

Hadoop QA commented on PHOENIX-4099:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12882508/PHOENIX-4099_v2.patch
  against master branch at commit ab67f30278bbf98338b2b347524e0bd17923257f.
  ATTACHMENT ID: 12882508

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 10 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 56 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 3 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +            throw new IllegalArgumentException("Unknown ReplayWrite code of " + Bytes.toStringBinary(replayWriteBytes));
+                    mutation.setAttribute(BaseScannerRegionObserver.REPLAY_WRITES, BaseScannerRegionObserver.REPLAY_TABLE_AND_INDEX_WRITES);
+      boolean resetTimeStamp = replayWrite == null && !isProbablyClientControlledTimeStamp(firstMutation);
+            Pair<ValueGetter, IndexUpdate> statePair = state.getIndexUpdateState(maintainer.getAllColumns(), metaData.getReplayWrite() != null, false, context);
+            Pair<ValueGetter, IndexUpdate> statePair = state.getIndexUpdateState(cols, metaData.getReplayWrite() != null, true, context);
+                        put.setAttribute(BaseScannerRegionObserver.REPLAY_WRITES, BaseScannerRegionObserver.REPLAY_ONLY_INDEX_WRITES);
+                        del.setAttribute(BaseScannerRegionObserver.REPLAY_WRITES, BaseScannerRegionObserver.REPLAY_ONLY_INDEX_WRITES);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.phoenix.hbase.index.covered.NonTxIndexBuilderTest
                  org.apache.phoenix.hbase.index.covered.update.TestIndexUpdateManager

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1276//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1276//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1276//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1276//console

This message is automatically generated.

> Do not write table data again when replaying mutations for partial index rebuild
> --------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4099
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4099
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4099.patch, PHOENIX-4099_v2.patch
>
>
> There's no need to re-write the data table mutations when we're replaying them to partially rebuild the index.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)