phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4122) Prevent IllegalMonitorStateException from occurring when releasing row locks
Date Thu, 24 Aug 2017 23:16:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140911#comment-16140911
] 

Hadoop QA commented on PHOENIX-4122:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12883606/PHOENIX-4122.patch
  against master branch at commit dd008f4fe4e67836a6fb362843c9618e4e518182.
  ATTACHMENT ID: 12883606

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 56 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +      public List<RowLock> rowLocks = Lists.newArrayListWithExpectedSize(QueryServicesOptions.DEFAULT_MUTATE_BATCH_SIZE);
+  private void setBatchMutateContext(ObserverContext<RegionCoprocessorEnvironment>
c, BatchMutateContext context) {
+  private BatchMutateContext getBatchMutateContext(ObserverContext<RegionCoprocessorEnvironment>
c) {
+  private void doPost(ObserverContext<RegionCoprocessorEnvironment> c, BatchMutateContext
context) throws IOException {
+  private void doPostWithExceptions(ObserverContext<RegionCoprocessorEnvironment> c,
BatchMutateContext context)

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AggregateQueryIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1295//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1295//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1295//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1295//console

This message is automatically generated.

> Prevent IllegalMonitorStateException from occurring when releasing row locks
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-4122
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4122
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4122.patch
>
>
> In this iteration, after RS process was killed, Indexes were disabled and soon its status
was changed to INACTIVE state.
> After all regions were re-assigned, we observed that two RS were aborted with below exception
in logs
> {code}
> org.apache.phoenix.hbase.index.Indexer threw java.lang.IllegalMonitorStateException
> java.lang.IllegalMonitorStateException
>         at java.util.concurrent.locks.ReentrantLock$Sync.tryRelease(ReentrantLock.java:151)
>         at java.util.concurrent.locks.AbstractQueuedSynchronizer.release(AbstractQueuedSynchronizer.java:1261)
>         at java.util.concurrent.locks.ReentrantLock.unlock(ReentrantLock.java:457)
>         at org.apache.phoenix.hbase.index.LockManager$RowLockImpl.release(LockManager.java:223)
>         at org.apache.phoenix.hbase.index.LockManager$RowLockContext.releaseRowLock(LockManager.java:166)
>         at org.apache.phoenix.hbase.index.LockManager.unlockRow(LockManager.java:131)
>         at org.apache.phoenix.hbase.index.Indexer.postBatchMutateIndispensably(Indexer.java:590)
>         at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$37.call(RegionCoprocessorHost.java:1023)
>         at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionOperation.call(RegionCoprocessorHost.java:1621)
>         at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.execOperation(RegionCoprocessorHost.java:1697)
>         at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.execOperation(RegionCoprocessorHost.java:1653)
>         at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postBatchMutateIndispensably(RegionCoprocessorHost.java:1019)
>         at org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutation(HRegion.java:2837)
>         at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:2410)
>         at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:2365)
>         at org.apache.phoenix.coprocessor.UngroupedAggregateRegionObserver.commitBatch(UngroupedAggregateRegionObserver.java:225)
>         at org.apache.phoenix.coprocessor.UngroupedAggregateRegionObserver.commit(UngroupedAggregateRegionObserver.java:791)
>         at org.apache.phoenix.coprocessor.UngroupedAggregateRegionObserver.doPostScannerOpen(UngroupedAggregateRegionObserver.java:705)
>         at org.apache.phoenix.coprocessor.BaseScannerRegionObserver$RegionScannerHolder.overrideDelegate(BaseScannerRegionObserver.java:255)
>         at org.apache.phoenix.coprocessor.BaseScannerRegionObserver$RegionScannerHolder.nextRaw(BaseScannerRegionObserver.java:306)
>         at org.apache.hadoop.hbase.regionserver.HRegionServer.scan(HRegionServer.java:3361)
>         at org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32492)
>         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2210)
>         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:104)
>         at org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:133)
>         at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:108)
>         at java.lang.Thread.run(Thread.java:745)
> 2017-08-24 07:47:19,916 FATAL [4,queue=4,port=60020] regionserver.HRegionServer - ABORTING
region server 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message