phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4110) ParallelRunListener should monitor number of tables and not number of tests
Date Wed, 23 Aug 2017 17:34:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138718#comment-16138718
] 

Josh Elser commented on PHOENIX-4110:
-------------------------------------

[~samarthjain], yeah, I do know. I stumbled across this the other week.

{noformat}
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/dev/test-patch.sh: line 488:
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/dev/smart-apply-patch.sh: No
such file or directory
{noformat}

For whatever reason, these files don't exist in the 0.98 branch. I don't know if there's a
reason (I'm also surprised at myself that I didn't just add the file...). Sorry about that.

> ParallelRunListener should monitor number of tables and not number of tests
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-4110
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4110
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-4110.patch, PHOENIX-4110_V2_4.x-HBase-0.98.patch, PHOENIX-4110_v3.patch
>
>
> ParallelRunListener today monitors the number of tests that have been run to determine
when mini cluster should be shut down. This helps prevent our test JVM forks running in OOM.
A better heuristic would be to instead check the number of tables that were created by tests.
This way when a particular test class has created lots of tables, we can shut down the mini
cluster sooner.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message