phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4096) Disallow DML operations on connections with CURRENT_SCN set
Date Wed, 30 Aug 2017 18:03:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147700#comment-16147700
] 

James Taylor commented on PHOENIX-4096:
---------------------------------------

There are about 20 more tests derived from BaseClientManagedTimeIT classes that need to be
converted before we can disallow DML and DDL on connections that set CURRENT_SCN. See my patch
for ones I've already converted - pretty straightforward - just use unique table names and
get rid of usage of CURRENT_SCN as these tests don't need it. If you can help, then please
indicate which tests you're converting so we don't duplicate our efforts, [~vincentpoon],
[~samarthjain], [~aertoria], [~tdsilva].

> Disallow DML operations on connections with CURRENT_SCN set
> -----------------------------------------------------------
>
>                 Key: PHOENIX-4096
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4096
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>         Attachments: PHOENIX-4096_wip.patch
>
>
> We should make a connection read-only if CURRENT_SCN is set. It's really a bad idea to
go back in time and update data and it won't work with secondary indexing, potentially leading
to your index and table getting out of sync.
> For testing purposes, where we need to control the timestamp, we should rely on the EnvironmentEdgeManager
instead to control the current time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message