phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4088) SQLExceptionCode.java code beauty and typos
Date Thu, 17 Aug 2017 16:30:01 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130765#comment-16130765
] 

Hadoop QA commented on PHOENIX-4088:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12882146/PHOENIX-4088.patch
  against master branch at commit b13413614fef3cdb87233fd1543081e7198d685f.
  ATTACHMENT ID: 12882146

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 56 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            + QueryServices.IS_NAMESPACE_MAPPING_ENABLED + " for enabling name space
mapping isn't enabled."),
+    INCONSISTENT_NAMESPACE_MAPPING_PROPERTIES(726, "43M10", " Inconsistent namespace mapping
properties.."),

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1267//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1267//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1267//console

This message is automatically generated.

> SQLExceptionCode.java code beauty and typos
> -------------------------------------------
>
>                 Key: PHOENIX-4088
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4088
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.8.0
>            Reporter: Csaba Skrabak
>            Assignee: Csaba Skrabak
>            Priority: Trivial
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4088.patch
>
>
> * Fix typos in log message strings
> * Fix typo in enum constant name introduced in PHOENIX-2862
> * Organize line breaks around the last enum constants like they are in the top ones



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message