phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3655) Metrics for PQS
Date Fri, 25 Aug 2017 16:44:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141849#comment-16141849
] 

Josh Elser commented on PHOENIX-3655:
-------------------------------------

I'm finding it difficult to weigh in because the scope of what you want to do is very broad,
[~rahulshrivastava]. We've touched on many things already here:

* Existing metrics being collected in Avatica already
* Existing metrics being collected by the PhoenixDriver (inside PQS) already
* HTrace to do runtime analysis of specific actions
* The use of the new hbase-metrics-api for aggregation of metrics data

Re-reading this issue's description, as well as the supplemental PDF, we immediately dive
into how to do the metrics work, not thinking about what kind of information we want (and
basing how to implement collection/reporting on that information). I think it would make sense
to take a step bad and consider what the high-level goals are: list the things we want to
measure, consider what the tools already at our disposal do, and what gaps exist from letting
us observe the things we want to measure.

> Metrics for PQS
> ---------------
>
>                 Key: PHOENIX-3655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3655
>             Project: Phoenix
>          Issue Type: New Feature
>    Affects Versions: 4.8.0
>         Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
>            Reporter: Rahul Shrivastava
>            Assignee: Rahul Shrivastava
>             Fix For: 4.12.0
>
>         Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client. Metrics collection
is currently done by PhoenixRuntime.java i.e. at Phoenix driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need capability to collect
metrics at PQS level and push the data to external sink i.e. file, JMX , other external custom
sources. 
> 2. Besides this global metrics could be periodically collected and pushed to the sink.

> 2. PQS can be configured to turn on metrics collection and type of collect ( runtime
or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml. 
> All metrics definition https://phoenix.apache.org/metrics.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message