Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A682D200CC8 for ; Fri, 14 Jul 2017 19:58:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A3A5D16E1AC; Fri, 14 Jul 2017 17:58:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EA22A16E1A9 for ; Fri, 14 Jul 2017 19:58:03 +0200 (CEST) Received: (qmail 93391 invoked by uid 500); 14 Jul 2017 17:58:02 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 93380 invoked by uid 99); 14 Jul 2017 17:58:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jul 2017 17:58:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 46EDD1A077B for ; Fri, 14 Jul 2017 17:58:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id O_-hBQuqk3vw for ; Fri, 14 Jul 2017 17:58:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4DE105F6C4 for ; Fri, 14 Jul 2017 17:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9027FE0984 for ; Fri, 14 Jul 2017 17:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 42D8624736 for ; Fri, 14 Jul 2017 17:58:00 +0000 (UTC) Date: Fri, 14 Jul 2017 17:58:00 +0000 (UTC) From: "Geoffrey Jacoby (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-4025) Make CachingHTableFactory thread-safe for 0.98 branch MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 14 Jul 2017 17:58:04 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087694#comment-16087694 ] Geoffrey Jacoby commented on PHOENIX-4025: ------------------------------------------ [~jamestaylor] - if that's the case, I'm all for getting rid of it everywhere too. Getting CachingHTableFactory to be thread-safe is possible but definitely non-trivial -- lots of edge cases in distinguishing cache eviction from normal user release. > Make CachingHTableFactory thread-safe for 0.98 branch > ----------------------------------------------------- > > Key: PHOENIX-4025 > URL: https://issues.apache.org/jira/browse/PHOENIX-4025 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.11.0 > Reporter: Geoffrey Jacoby > Assignee: Geoffrey Jacoby > Fix For: 4.12.0 > > > CachingHTableFactory, which is used in global index writes, isn't thread-safe (see discussion in PHOENIX-4021) and will be removed in the master and 4.x-HBase-1.x branches. However, according to PHOENIX-3159 it's still needed in HBase 0.98-based Phoenix because creating HTables is still heavy-weight in 0.98. > This means it needs to be made thread-safe. Current plan is when an HTable's requested, check the reference count (which is already tracked for cleanup purposes) and if the count is 1, create a new HTable. We'll cache lists of identical HTables per HBase table, rather than 1 HTable per HBase table. -- This message was sent by Atlassian JIRA (v6.4.14#64029)