Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Mon, 10 Jul 2017 17:38:00 +0000 (UTC)
From: "James Taylor (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13085296.1499366185000.209338.1499708280173@Atlassian.JIRA>
In-Reply-To: <JIRA.13085296.1499366185000@Atlassian.JIRA>
References: <JIRA.13085296.1499366185000@Atlassian.JIRA> <JIRA.13085296.1499366185107@jira-lw-us.apache.org>
Subject: [jira] [Commented] (PHOENIX-3997)
 UngroupedAggregateRegionObserver.commitBatchWithHTable() should not check
 the memstore size and wait for flush.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 10 Jul 2017 17:38:06 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080718#comment-16080718 ] 

James Taylor commented on PHOENIX-3997:
---------------------------------------

Just wanted to follow up on this, [~gjacoby]. I think we should keep the check only in the case where the source and target tables are the same. We'd need an additional boolean to be passed through commitBatchWithHTable and conditionally do the check if true in this case:
{code}
boolean isSameTable = Bytes.compareTo(targetHTable.getTableName(),
                    region.getTableDesc().getTableName().getName()) == 0
{code}

> UngroupedAggregateRegionObserver.commitBatchWithHTable() should not check the memstore size and wait for flush. 
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3997
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3997
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Thomas D'Silva
>            Assignee: Geoffrey Jacoby
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-3997.patch
>
>
> [~ankit.singhal] 
> In UngroupedAggregateRegionObserver.commitBatchWithHTable() do we need to check the memstore size and wait for the flush. We are using a htable to write the mutations.
> {code}
>  // When memstore size reaches blockingMemstoreSize we are waiting 3 seconds for the
>         // flush happen which decrease the memstore size and then writes allowed on the region.
>         for (int i = 0; region.getMemstoreSize().get() > blockingMemstoreSize && i < 30; i++) {
>             try {
>                 checkForRegionClosing();
>                 Thread.sleep(100);
>             } catch (InterruptedException e) {
>                 Thread.currentThread().interrupt();
>                 throw new IOException(e);
>             }
>         }
>         logger.debug("Committing batch of " + mutations.size() + " mutations for " + table);
>         try {
>             table.batch(mutations);
>         } catch (InterruptedException e) {
>             throw new RuntimeException(e);
>         }
> {code}
> FYI [~jamestaylor] [~apurtell]


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)