Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Mon, 24 Jul 2017 22:38:00 +0000 (UTC)
From: "Andrew Purtell (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13085296.1499366185000.1979.1500935880934@Atlassian.JIRA>
In-Reply-To: <JIRA.13085296.1499366185000@Atlassian.JIRA>
References: <JIRA.13085296.1499366185000@Atlassian.JIRA> <JIRA.13085296.1499366185107@jira-lw-us.apache.org>
Subject: [jira] [Commented] (PHOENIX-3997)
 UngroupedAggregateRegionObserver.commitBatchWithHTable() should not check
 the memstore size and wait for flush.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 24 Jul 2017 22:38:06 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099212#comment-16099212 ] 

Andrew Purtell commented on PHOENIX-3997:
-----------------------------------------

Committing shortly. 

> UngroupedAggregateRegionObserver.commitBatchWithHTable() should not check the memstore size and wait for flush. 
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3997
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3997
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Thomas D'Silva
>            Assignee: Geoffrey Jacoby
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-3997.patch, PHOENIX-3997-v2.patch, PHOENIX-3997-v3.patch
>
>
> [~ankit.singhal] 
> In UngroupedAggregateRegionObserver.commitBatchWithHTable() do we need to check the memstore size and wait for the flush. We are using a htable to write the mutations.
> {code}
>  // When memstore size reaches blockingMemstoreSize we are waiting 3 seconds for the
>         // flush happen which decrease the memstore size and then writes allowed on the region.
>         for (int i = 0; region.getMemstoreSize().get() > blockingMemstoreSize && i < 30; i++) {
>             try {
>                 checkForRegionClosing();
>                 Thread.sleep(100);
>             } catch (InterruptedException e) {
>                 Thread.currentThread().interrupt();
>                 throw new IOException(e);
>             }
>         }
>         logger.debug("Committing batch of " + mutations.size() + " mutations for " + table);
>         try {
>             table.batch(mutations);
>         } catch (InterruptedException e) {
>             throw new RuntimeException(e);
>         }
> {code}
> FYI [~jamestaylor] [~apurtell]


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)