Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B11CF200CCF for ; Mon, 24 Jul 2017 17:33:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AFBAE16557A; Mon, 24 Jul 2017 15:33:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 23F9C165576 for ; Mon, 24 Jul 2017 17:33:14 +0200 (CEST) Received: (qmail 1934 invoked by uid 500); 24 Jul 2017 15:33:13 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 1547 invoked by uid 99); 24 Jul 2017 15:33:12 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jul 2017 15:33:12 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6BC91DFF8A; Mon, 24 Jul 2017 15:33:10 +0000 (UTC) From: joshelser To: dev@phoenix.apache.org Reply-To: dev@phoenix.apache.org References: In-Reply-To: Subject: [GitHub] phoenix pull request #236: PHOENIX-3654 Load Balancer for thin client Content-Type: text/plain Message-Id: <20170724153311.6BC91DFF8A@git1-us-west.apache.org> Date: Mon, 24 Jul 2017 15:33:10 +0000 (UTC) archived-at: Mon, 24 Jul 2017 15:33:15 -0000 Github user joshelser commented on a diff in the pull request: https://github.com/apache/phoenix/pull/236#discussion_r129067998 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java --- @@ -255,9 +255,16 @@ public static final String DEFAULT_COLUMN_ENCODED_BYTES_ATRRIB = "phoenix.default.column.encoded.bytes.attrib"; public static final String DEFAULT_IMMUTABLE_STORAGE_SCHEME_ATTRIB = "phoenix.default.immutable.storage.scheme"; public static final String DEFAULT_MULTITENANT_IMMUTABLE_STORAGE_SCHEME_ATTRIB = "phoenix.default.multitenant.immutable.storage.scheme"; + + public final static String PHOENIX_QUERY_SERVER_CLUSTER_BASE_PATH = "phoenix.queryserver.base.path"; + public final static String PHOENIX_QUERY_SERVER_SERVICE_NAME = "phoenix.queryserver.service.name"; + public final static String PHOENIX_QUERY_SERVER_ZK_ACL_USERNAME = "phoenix.queryserver.zookeeper.acl.username"; + public final static String PHOENIX_QUERY_SERVER_ZK_ACL_PASSWORD = "phoenix.queryserver.zookeeper.acl.password"; --- End diff -- Nit: please match the style "public static final" not "public final static" (emphasis also on the two spaces) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---