phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4028) Provide option to not throw index write failure back to client
Date Mon, 17 Jul 2017 19:54:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090444#comment-16090444
] 

Hadoop QA commented on PHOENIX-4028:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12877634/PHOENIX-4028_v3.patch
  against master branch at commit 7a83b8a1c4c9cefb6027b9aa2020af1dd18b599a.
  ATTACHMENT ID: 12877634

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 51 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +        ddl = "CREATE VIEW " + viewFullName + " AS SELECT * FROM " + dataTableFullName
+ " WHERE CREATION_TIME = 1 THROW_INDEX_WRITE_FAILURE = FALSE";
+    public MutableIndexFailureIT(boolean transactional, boolean localIndex, boolean isNamespaceMapped,
Boolean disableIndexOnWriteFailure, Boolean rebuildIndexOnWriteFailure, boolean failRebuildTask,
Boolean throwIndexWriteFailure) {
+                + (rebuildIndexOnWriteFailure == null ? "" : (", " + PhoenixIndexFailurePolicy.REBUILD_INDEX_ON_WRITE_FAILURE
+ "=" + rebuildIndexOnWriteFailure))
+                + (throwIndexWriteFailure == null ? "" : (", " + PhoenixIndexFailurePolicy.THROW_INDEX_WRITE_FAILURE
+ "=" + throwIndexWriteFailure));
+    @Parameters(name = "MutableIndexFailureIT_transactional={0},localIndex={1},isNamespaceMapped={2},disableIndexOnWriteFailure={3},rebuildIndexOnWriteFailure={4},failRebuildTask={5},throwIndexWriteFailure={6}")
// name is used by failsafe as file name in reports
+                            "SELECT INDEX_STATE, INDEX_DISABLE_TIMESTAMP FROM SYSTEM.CATALOG
WHERE TABLE_SCHEM = '"
+	        throwIndexWriteFailure = env.getConfiguration().getBoolean(QueryServices.INDEX_FAILURE_THROW_EXCEPTION_ATTRIB,
+            	IOException ioException = ServerUtil.wrapInDoNotRetryIOException("Unable to
update the following indexes: " + attempted.keySet(), cause, timestamp);
+    public static final String INDEX_FAILURE_THROW_EXCEPTION_ATTRIB = "phoenix.index.failure.throw.exception";

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.GroupByIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1224//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1224//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1224//console

This message is automatically generated.

> Provide option to not throw index write failure back to client
> --------------------------------------------------------------
>
>                 Key: PHOENIX-4028
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4028
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4028.patch, PHOENIX-4028_v2.patch, PHOENIX-4028_v3.patch,
PHOENIX-4028_v4.patch, PHOENIX-4028_wip.patch
>
>
> Much like our DISABLE_INDEX_ON_WRITE_FAILURE and REBUILD_INDEX_ON_WRITE_FAILURE table
properties, we need a THROW_INDEX_WRITE_FAILURE boolean option that can be used to prevent
the index write from being thrown back to the client. In this case, the index failure policy
would still be executed (i.e. disabling the index on a write failure), but any retry logic
for the client would be avoided. The index would be eventually consistent based on the background
partial index rebuild thread.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message