phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas D'Silva (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-4022) Add PhoenixMetricsLog interface that can be used to log metrics for queries and mutations.
Date Wed, 19 Jul 2017 03:30:00 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas D'Silva updated PHOENIX-4022:
------------------------------------
    Attachment: PHOENIX-4022-v2.patch

[~jamestaylor]

Thanks for the review. I have attached a v2 patch. I forgot to include the following change
to the PreparedStatement and PhoenixPreparedStatement wrappers. We don't want users to be
able to override the query timeout using a Statement. 
I renamed the ResultSet and Connection wrappers to use the Logging prefix, but used the Protected
prefix for PreparedStatement and PhoenixPreparedStatement. 

{code}
+    @Override
+    public void setQueryTimeout(int seconds) throws SQLException {
+        throw new UnsupportedOperationException("ProtectedPhoenixStatement does not support
setQueryTimeout");
+    }
{code}

> Add PhoenixMetricsLog interface that can be used to log metrics for queries and mutations.

> -------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4022
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4022
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4022.patch, PHOENIX-4022-v2.patch
>
>
> Create a wrapper for PhoenixConnection, PhoenixStatement, PhoenixPreparedStatement and
PhoenixResultSet that automatically calls the PhoenixMetricsLog logging methods so users don't
have to instrument this themselves.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message