phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-4004) Assorted improvements to reduce garbage in mutable index codepath
Date Fri, 21 Jul 2017 23:36:01 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096997#comment-16096997
] 

Hudson commented on PHOENIX-4004:
---------------------------------

FAILURE: Integrated in Jenkins build Phoenix-master #1701 (See [https://builds.apache.org/job/Phoenix-master/1701/])
PHOENIX-4004 Remove unnecessary allocations in server-side mutable (elserj: rev 87976eb6f9892ab8c20f38db5e1cef3934ec2b89)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/LocalTableState.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/builder/IndexBuildManager.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/example/CoveredColumnIndexCodec.java


> Assorted improvements to reduce garbage in mutable index codepath
> -----------------------------------------------------------------
>
>                 Key: PHOENIX-4004
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4004
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Minor
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4004.001.patch, PHOENIX-4004.002.patch
>
>
> During some $dayjob testing, I found a couple of places where we were unnecessarily creating
garbage in the RS. When "forward-porting" this change, most of the areas were already cleaned
up but there are a few that still apply.
> * ArrayList initial sizing
> * Avoid indirection of the (single-threaded) ExecutorService in IndexBuildManager (just
pure overhead)
> * Some unnecessary KeyValue copies and an array copy (an avoidance of deprecated HBase
API)
> * Avoid extra {{System.arraycopy}} calls in CoveredColumnIndexCodec via the {{ArrayUtils.addAll}}
call



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message