phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas D'Silva (JIRA)" <j...@apache.org>
Subject [jira] [Created] (PHOENIX-3997) UngroupedAggregateRegionObserver.commitBatchWithHTable() should not check the memstore size and wait for flush.
Date Thu, 06 Jul 2017 18:37:00 GMT
Thomas D'Silva created PHOENIX-3997:
---------------------------------------

             Summary: UngroupedAggregateRegionObserver.commitBatchWithHTable() should not
check the memstore size and wait for flush. 
                 Key: PHOENIX-3997
                 URL: https://issues.apache.org/jira/browse/PHOENIX-3997
             Project: Phoenix
          Issue Type: Bug
            Reporter: Thomas D'Silva
             Fix For: 4.9.0


[~ankit.singhal] 

In UngroupedAggregateRegionObserver.commitBatchWithHTable() do we need to check the memstore
size and wait for the flush. We are using a htable to write the mutations.
{code}
 // When memstore size reaches blockingMemstoreSize we are waiting 3 seconds for the
        // flush happen which decrease the memstore size and then writes allowed on the region.
        for (int i = 0; region.getMemstoreSize().get() > blockingMemstoreSize &&
i < 30; i++) {
            try {
                checkForRegionClosing();
                Thread.sleep(100);
            } catch (InterruptedException e) {
                Thread.currentThread().interrupt();
                throw new IOException(e);
            }
        }
        logger.debug("Committing batch of " + mutations.size() + " mutations for " + table);
        try {
            table.batch(mutations);
        } catch (InterruptedException e) {
            throw new RuntimeException(e);
        }
{code}

FYI [~jamestaylor] [~apurtell]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message