phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml
Date Sat, 15 Jul 2017 08:44:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088523#comment-16088523
] 

William Yang commented on PHOENIX-3994:
---------------------------------------

First, I'm deeply sorry for the committed patch not working in PHOENIX-3360.  Please accept
my apologies.

What is being used in my production env is the [PHOENIX-3360-V3.patch|https://issues.apache.org/jira/secure/attachment/12851796/PHOENIX-3360-v3.PATCH]
which is the simplest effective way to solve this problem. But that patch was rejected by
using HBase internal class CoprocessorHConnection directly then I came up with the [PHOENIX-3360-V4.patch|https://issues.apache.org/jira/secure/attachment/12852511/PHOENIX-3360-v4.PATCH]
which is unfortunately not working. As I saw in the final patch of this issue, CoprocessorHConnection
is still created directly from phoenix' code. If so, why can't we just using the V3 patch
instead? 

More over I think the only reason V4 is not working is because HBASE-18359, right? Besides,
modify the env's configuration object is also not recommended according to what [~apurtell]
said. If we have to clone the config then we cannot use the env's getTable() method as it
cannot see the cloned/modified config, even though we get HBASE-18359 fixed.  I'll test it
this weekend. 

So, what say you, [~samarthjain], [~jamestaylor]?

> Index RPC priority still depends on the controller factory property in hbase-site.xml
> -------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3994
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3994
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.11.0
>            Reporter: Sergey Soldatov
>            Assignee: Samarth Jain
>            Priority: Critical
>             Fix For: 4.12.0, 4.11.1
>
>         Attachments: PHOENIX-3994_addendum.patch, PHOENIX-3994.patch, PHOENIX-3994_v2.patch,
PHOENIX-3994_v3.patch, PHOENIX-3994_v4.patch, PHOENIX-3994_v5.patch
>
>
> During PHOENIX-3360 we tried to remove dependency on hbase.rpc.controllerfactory.class
property in hbase-site.xml since it cause problems on the client side (if client is using
server side configuration, all client request may go using index priority). Committed solution
is using setting the controller factory programmatically for coprocessor environment in Indexer
class, but it comes that this solution doesn't work because the environment configuration
is not used for the coprocessor connection creation. We need to provide a better solution
since this issue may cause accidental locks and failures that hard to identify and avoid.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message