phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml
Date Thu, 13 Jul 2017 19:23:00 GMT


James Taylor commented on PHOENIX-3994:

One other question: shouldn't we be using the coprocessor based HTable factory to get this
HTable. Getting an HTable in this way I don't think is recommended:
     private void commitBatch(Region region, List<Mutation> mutations, byte[] indexUUID,
long blockingMemstoreSize,
@@ -392,7 +409,7 @@ public class UngroupedAggregateRegionObserver extends BaseScannerRegionObserver
         if (upsertSelectTable != null) {
             isUpsert = true;
             projectedTable = deserializeTable(upsertSelectTable);
-            targetHTable = new HTable(env.getConfiguration(), projectedTable.getPhysicalName().getBytes());
+            targetHTable = new HTable(upsertSelectConfig, projectedTable.getPhysicalName().getBytes());

> Index RPC priority still depends on the controller factory property in hbase-site.xml
> -------------------------------------------------------------------------------------
>                 Key: PHOENIX-3994
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.11.0
>            Reporter: Sergey Soldatov
>            Assignee: Samarth Jain
>            Priority: Critical
>             Fix For: 4.12.0, 4.11.1
>         Attachments: PHOENIX-3994_addendum.patch, PHOENIX-3994.patch, PHOENIX-3994_v2.patch,
PHOENIX-3994_v3.patch, PHOENIX-3994_v4.patch, PHOENIX-3994_v5.patch
> During PHOENIX-3360 we tried to remove dependency on hbase.rpc.controllerfactory.class
property in hbase-site.xml since it cause problems on the client side (if client is using
server side configuration, all client request may go using index priority). Committed solution
is using setting the controller factory programmatically for coprocessor environment in Indexer
class, but it comes that this solution doesn't work because the environment configuration
is not used for the coprocessor connection creation. We need to provide a better solution
since this issue may cause accidental locks and failures that hard to identify and avoid.

This message was sent by Atlassian JIRA

View raw message