phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-3994) Index RPC priority still depends on the controller factory property in hbase-site.xml
Date Thu, 06 Jul 2017 20:15:00 GMT


James Taylor commented on PHOENIX-3994:

I think we'd lose an important optimization if we don't go through CoprocessorHConnection.
Index updates that happen to be local bypass the RPC stack entirely. I suspect you wouldn't
get this if you went through an HConnection created by HConnectionManager.

Can we do any changes related to default UPSERT SELECT on server side in a separate JIRA?
I think rather than change the default, we should detect if the target table in the UPSERT
SELECT has mutable indexes and in that case run it on the client instead (until PHOENIX-3995
can be fixed which may not be until HBASE-15816 is fixed because I don't think we can know
that we're running an UPSERT SELECT from the RPC controller factory).

> Index RPC priority still depends on the controller factory property in hbase-site.xml
> -------------------------------------------------------------------------------------
>                 Key: PHOENIX-3994
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.11.0
>            Reporter: Sergey Soldatov
>            Priority: Critical
>         Attachments: PHOENIX-3994.patch
> During PHOENIX-3360 we tried to remove dependency on hbase.rpc.controllerfactory.class
property in hbase-site.xml since it cause problems on the client side (if client is using
server side configuration, all client request may go using index priority). Committed solution
is using setting the controller factory programmatically for coprocessor environment in Indexer
class, but it comes that this solution doesn't work because the environment configuration
is not used for the coprocessor connection creation. We need to provide a better solution
since this issue may cause accidental locks and failures that hard to identify and avoid.

This message was sent by Atlassian JIRA

View raw message