phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Samarth Jain (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3978) Expose mutation failures in our metrics
Date Thu, 13 Jul 2017 02:07:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085048#comment-16085048
] 

Samarth Jain commented on PHOENIX-3978:
---------------------------------------

[~tdsilva], looks like your checkin broke unit tests. 

{code}
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.019 s <<<
FAILURE! - in org.apache.phoenix.metrics.MetricTypeTest
[ERROR] testUniqueShortNames(org.apache.phoenix.metrics.MetricTypeTest)  Time elapsed: 0.018
s  <<< FAILURE!
java.lang.AssertionError: Metric short names should be unique found duplicates for MEMORY_CHUNK_BYTES
and MUTATION_BATCH_SIZE
        at org.apache.phoenix.metrics.MetricTypeTest.testUniqueShortNames(MetricTypeTest.java:37)
{code}


> Expose mutation failures in our metrics
> ---------------------------------------
>
>                 Key: PHOENIX-3978
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3978
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Thomas D'Silva
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-3978-4.x-HBase-0.98-v2.patch, PHOENIX-3978-4.x-HBase-0.98-v3.patch,
PHOENIX-3978.patch, PHOENIX-3978-v2.patch
>
>
> We should be exposing whether a mutation has failed through our metrics system. This
should be done both within global and request level metrics. 
> The task basically boils down to:
> 1) Adding a new enum MUTATION_BATCH_FAILED_COUNTER in MetricType.
> 2) Adding a new enum GLOBAL_MUTATION_BATCH_FAILED_COUNTER in GlobalClientMetrics
> 3) Adding a new CombinableMetric member called mutationBatchFailed to MutationMetric
class
> 4) Making sure that the two metrics are updated within the catch exception block of MutationState#send()
> 5) Unit test in PhoenixMetricsIT
> FYI, [~tdsilva]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message