phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3978) Expose mutation failures in our metrics
Date Wed, 12 Jul 2017 22:28:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084841#comment-16084841
] 

Hudson commented on PHOENIX-3978:
---------------------------------

FAILURE: Integrated in Jenkins build Phoenix-master #1683 (See [https://builds.apache.org/job/Phoenix-master/1683/])
PHOENIX-3978 Expose mutation failures in our metrics (thomas: rev e05b7cdd3286d7021d5836ecf7446a1c2aed0b9c)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/CombinableMetric.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixResultSet.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java
* (add) phoenix-core/src/test/java/org/apache/phoenix/metrics/MetricTypeTest.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/MutationMetricQueue.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/OverAllQueryMetrics.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/NonAtomicMetric.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/execute/PartialCommitIT.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricImpl.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricType.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/ReadMetricQueue.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/AtomicMetric.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalClientMetrics.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/Metric.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/CombinableMetricImpl.java


> Expose mutation failures in our metrics
> ---------------------------------------
>
>                 Key: PHOENIX-3978
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3978
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Thomas D'Silva
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-3978-4.x-HBase-0.98-v2.patch, PHOENIX-3978-4.x-HBase-0.98-v3.patch,
PHOENIX-3978.patch, PHOENIX-3978-v2.patch
>
>
> We should be exposing whether a mutation has failed through our metrics system. This
should be done both within global and request level metrics. 
> The task basically boils down to:
> 1) Adding a new enum MUTATION_BATCH_FAILED_COUNTER in MetricType.
> 2) Adding a new enum GLOBAL_MUTATION_BATCH_FAILED_COUNTER in GlobalClientMetrics
> 3) Adding a new CombinableMetric member called mutationBatchFailed to MutationMetric
class
> 4) Making sure that the two metrics are updated within the catch exception block of MutationState#send()
> 5) Unit test in PhoenixMetricsIT
> FYI, [~tdsilva]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message