phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas D'Silva (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-3978) Expose mutation failures in our metrics
Date Tue, 11 Jul 2017 23:18:00 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas D'Silva updated PHOENIX-3978:
------------------------------------
    Attachment: PHOENIX-3978-v2.patch
                PHOENIX-3978-4.x-HBase-0.98-v2.patch

[~samarthjain]

Thanks for the review. I have attached a v2 patch.

> Expose mutation failures in our metrics
> ---------------------------------------
>
>                 Key: PHOENIX-3978
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3978
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Thomas D'Silva
>         Attachments: PHOENIX-3978-4.x-HBase-0.98-v2.patch, PHOENIX-3978.patch, PHOENIX-3978-v2.patch
>
>
> We should be exposing whether a mutation has failed through our metrics system. This
should be done both within global and request level metrics. 
> The task basically boils down to:
> 1) Adding a new enum MUTATION_BATCH_FAILED_COUNTER in MetricType.
> 2) Adding a new enum GLOBAL_MUTATION_BATCH_FAILED_COUNTER in GlobalClientMetrics
> 3) Adding a new CombinableMetric member called mutationBatchFailed to MutationMetric
class
> 4) Making sure that the two metrics are updated within the catch exception block of MutationState#send()
> 5) Unit test in PhoenixMetricsIT
> FYI, [~tdsilva]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message