phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3947) Increase scan time out for partial index rebuild and retry only once
Date Fri, 07 Jul 2017 02:32:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077481#comment-16077481
] 

Hadoop QA commented on PHOENIX-3947:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12876008/PHOENIX-3947.patch
  against master branch at commit f5f32e3b8d111b47c3f5c83f4dfff4e4e7af6863.
  ATTACHMENT ID: 12876008

    {color:green} 1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green} 1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 49 warning messages.

    {color:green} 1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
         public static final String INDEX_REBUILD_QUERY_TIMEOUT_ATTRIB = "phoenix.index.rebuild.query.timeout";
     public static final String INDEX_REBUILD_RPC_TIMEOUT_ATTRIB = "phoenix.index.rebuild.rpc.timeout";
     public static final String INDEX_REBUILD_CLIENT_SCANNER_TIMEOUT_ATTRIB = "phoenix.index.rebuild.client.scanner.timeout";
     public static final String INDEX_REBUILD_RPC_RETRIES_COUNTER = "phoenix.index.rebuild.rpc.retries.counter";
     public static final String INDEX_REBUILD_RPC_RETRY_PAUSE_TIME = "phoenix.index.rebuild.rpc.retry.pause";

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PhoenixRuntimeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ClientTimeArithmeticQueryIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1177//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1177//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1177//console

This message is automatically generated.

> Increase scan time out for partial index rebuild and retry only once
> --------------------------------------------------------------------
>
>                 Key: PHOENIX-3947
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3947
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Samarth Jain
>              Labels: globalMutableSecondaryIndex
>         Attachments: PHOENIX-3947.patch, PHOENIX-3947_v2.patch
>
>
> The scan done from MetaDataRegionObserver needs to have a higher timeout so that it can
always complete successfully. The retries should be limited to one too. Upon failure, we should
disable the index and set the INDEX_DISABLE_TIMESTAMP to zero to prevent further attempts
to rebuild the index (as a failure would be an indication that something is awry and manual
intervention should be required to rebuild the index completely).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message