phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3525) Cap automatic index rebuilding to inactive timestamp.
Date Thu, 20 Jul 2017 21:01:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095359#comment-16095359
] 

James Taylor commented on PHOENIX-3525:
---------------------------------------

bq. In MetadataEndPointImpl I am setting the upper bound of the scan only when the index state
is being switched from disable to inactive. I am setting the upper bound timestamp either
when it is not set or when the index disable timestamp is newer than the existing upper bound.

We should set the upper bound timestamp to the <index disable timestamp> + 1 if that's
greater than the current value (regardless of the index state). This would be an indication
that more write failures are happening at a later time and it should prevent the unnecessary
replay when the index is left active as well. It's correct to set it to the timestamp at which
the index is being transitioned from disabled to active.

Why are we removing these lines from MetaDataEndPointImpl?
{code}
-                    // Done building, but was disable before that, so that in disabled state
-                    if (newState == PIndexState.ACTIVE) {
-                        newState = PIndexState.DISABLE;
-                    }
{code}

> Cap automatic index rebuilding to inactive timestamp.
> -----------------------------------------------------
>
>                 Key: PHOENIX-3525
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3525
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Ankit Singhal
>         Attachments: PHOENIX-3525_wip.patch
>
>
> From [~chrajeshbabu32@gmail.com] review comment on 
> https://github.com/apache/phoenix/pull/210
> For automatic rebuilding ,DISABLED_TIMESTAMP is lower bound but there is no upper bound
so we are going rebuild all the new writes written after DISABLED_TIMESTAMP even though indexes
updated properly. So we can introduce an upper bound of time where we are going to start a
rebuild thread so we can limit the data to rebuild. In case If there are frequent writes then
we can increment the rebuild period exponentially



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message