phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #268: PHOENIX-4010 Hash Join cache may not be send to a...
Date Tue, 25 Jul 2017 00:30:43 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/268#discussion_r129188027
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
    @@ -108,6 +126,10 @@ public TableResultIterator(MutationState mutationState, Scan scan,
ScanMetricsHo
             this.scanIterator = UNINITIALIZED_SCANNER;
             this.renewLeaseThreshold = renewLeaseThreshold;
             this.scanGrouper = scanGrouper;
    +        this.hashCacheClient = new HashCacheClient(plan.getContext().getConnection());
    +        this.caches = caches;
    +        this.retry=plan.getContext().getConnection().getQueryServices().getConfiguration()
    --- End diff --
    
    Can we use getProps() here instead of going through the Configuration object? We've found
the synchronization done by Configuration to be a bottleneck in the past (and not necessary
since these properties don't change).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message