phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix pull request #236: PHOENIX-3654 Load Balancer for thin client
Date Mon, 24 Jul 2017 15:33:10 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/236#discussion_r129069369
  
    --- Diff: phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/register/Registry.java
---
    @@ -0,0 +1,31 @@
    +/**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.queryserver.register;
    +
    +
    +import org.apache.phoenix.loadbalancer.service.LoadBalanceZookeeperConf;
    +
    +public interface  Registry  {
    +
    +    public void deRegisterTheServer() throws Exception;
    --- End diff --
    
    nit: `deregisterServer()` instead. Or, should it be `deregisterServers()`? Does it remove
all servers since it has no arguments? (javadoc here would also be nice :))
    
    Also, you can drop the `public` modifier -- this is unnecessary for interfaces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message