phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix pull request #236: PHOENIX-3654 Load Balancer for thin client
Date Mon, 24 Jul 2017 15:33:10 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/236#discussion_r129068605
  
    --- Diff: phoenix-load-balancer/pom.xml ---
    @@ -0,0 +1,84 @@
    +<?xml version='1.0'?>
    +<!--
    +
    + Licensed to the Apache Software Foundation (ASF) under one
    + or more contributor license agreements.  See the NOTICE file
    + distributed with this work for additional information
    + regarding copyright ownership.  The ASF licenses this file
    + to you under the Apache License, Version 2.0 (the
    + "License"); you may not use this file except in compliance
    + with the License.  You may obtain a copy of the License at
    +
    +   http://www.apache.org/licenses/LICENSE-2.0
    +
    + Unless required by applicable law or agreed to in writing,
    + software distributed under the License is distributed on an
    + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + KIND, either express or implied.  See the License for the
    + specific language governing permissions and limitations
    + under the License.
    +
    +-->
    +
    +<project xmlns="http://maven.apache.org/POM/4.0.0"
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +  <modelVersion>4.0.0</modelVersion>
    +  <parent>
    +    <groupId>org.apache.phoenix</groupId>
    +    <artifactId>phoenix</artifactId>
    +    <version>4.11.0-HBase-1.3-SNAPSHOT</version>
    +  </parent>
    +  <artifactId>phoenix-load-balancer</artifactId>
    +  <name>Phoenix Load Balancer</name>
    +  <description>A Load balancer which routes calls to Phoenix Query Server</description>
    +
    +  <dependencies>
    +    <dependency>
    +      <groupId>org.apache.hbase</groupId>
    +      <artifactId>hbase-common</artifactId>
    --- End diff --
    
    It looks like you're using a bunch of dependencies transitively. This will work for now,
but is brittle in the long term.
    
    We should make sure that this module depends directly on all of the dependencies that
it uses instead of relying on another dependency bringing them in. Can do this later though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message