phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] phoenix pull request #236: PHOENIX-3654 Load Balancer for thin client
Date Mon, 24 Jul 2017 15:33:10 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/236#discussion_r129067705
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
---
    @@ -284,14 +288,18 @@
         public static final int DEFAULT_COLUMN_ENCODED_BYTES = QualifierEncodingScheme.TWO_BYTE_QUALIFIERS.getSerializedMetadataValue();
         public static final String DEFAULT_IMMUTABLE_STORAGE_SCHEME = ImmutableStorageScheme.SINGLE_CELL_ARRAY_WITH_OFFSETS.toString();
         public static final String DEFAULT_MULTITENANT_IMMUTABLE_STORAGE_SCHEME = ImmutableStorageScheme.ONE_CELL_PER_COLUMN.toString();
    +    public  final static String DEFAULT_PHOENIX_QUERY_SERVER_CLUSTER_BASE_PATH = "/phoenix";
    +    public  final static String DEFAULT_PHOENIX_QUERY_SERVER_SERVICE_NAME = "queryserver";
    +    public  final static String DEFAULT_PHOENIX_QUERY_SERVER_ZK_ACL_USERNAME = "phoenixuser";
    +    public  final static String DEFAULT_PHOENIX_QUERY_SERVER_ZK_ACL_PASSWORD = "Xsjdhxsd";
     
         //by default, max connections from one client to one cluster is unlimited
         public static final int DEFAULT_CLIENT_CONNECTION_MAX_ALLOWED_CONNECTIONS = 0;
    -    public static final boolean DEFAULT_STATS_COLLECTION_ENABLED = true;
    -    public static final boolean DEFAULT_USE_STATS_FOR_PARALLELIZATION = true;
     
         //default update cache frequency
         public static final int DEFAULT_UPDATE_CACHE_FREQUENCY = 0;
    +    public static final boolean DEFAULT_STATS_COLLECTION_ENABLED = true;
    +    public static final boolean DEFAULT_USE_STATS_FOR_PARALLELIZATION = true;
    --- End diff --
    
    Nit: undo this move please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message