phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JamesRTaylor <...@git.apache.org>
Subject [GitHub] phoenix pull request #262: PHOENIX 153 implement TABLESAMPLE clause
Date Tue, 11 Jul 2017 19:02:27 GMT
Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/262#discussion_r126779550
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/SelectStatement.java ---
    @@ -267,6 +267,12 @@ public LimitNode getLimit() {
         }
         
         @Override
    +    public Double getTableSamplingRate(){
    +    	if(fromTable==null || !(fromTable instanceof ConcreteTableNode)) return null;
    +    	return ((ConcreteTableNode)fromTable).getTableSamplingRate();
    --- End diff --
    
    Do we need this method? What happens in the case of a join, where there are multiple concrete
tables? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message