Return-Path: <dev-return-42097-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 99200200CA8
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 15 Jun 2017 12:31:18 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 979BC160BDF; Thu, 15 Jun 2017 10:31:18 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 10923160BC4
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 15 Jun 2017 12:31:17 +0200 (CEST)
Received: (qmail 63877 invoked by uid 500); 15 Jun 2017 10:31:17 -0000
Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@phoenix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@phoenix.apache.org>
List-Post: <mailto:dev@phoenix.apache.org>
List-Id: <dev.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list dev@phoenix.apache.org
Received: (qmail 63860 invoked by uid 99); 15 Jun 2017 10:31:17 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jun 2017 10:31:17 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id B7565DFE15; Thu, 15 Jun 2017 10:31:16 +0000 (UTC)
From: brfrn169 <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-261-phoenix@git.apache.org>
In-Reply-To: <git-pr-261-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #261: PHOENIX-3944 ReadOnlyTableException occurs when w...
Content-Type: text/plain
Message-Id: <20170615103116.B7565DFE15@git1-us-west.apache.org>
Date: Thu, 15 Jun 2017 10:31:16 +0000 (UTC)
archived-at: Thu, 15 Jun 2017 10:31:18 -0000

Github user brfrn169 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/261#discussion_r122172275
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -2135,7 +2135,7 @@ private PTable createTableInternal(CreateTableStatement statement, byte[][] spli
                     // Upsert physical name for mapped view only if the full physical table name is different than the full table name
                     // Otherwise, we end up with a self-referencing link and then cannot ever drop the view.
                     if (viewType != ViewType.MAPPED
    -                        || !physicalNames.get(0).getString().equals(SchemaUtil.getTableName(schemaName, tableName))) {
    +                        || !physicalNames.get(0).getString().equals(SchemaUtil.getPhysicalName(schemaName, tableName))) {
    --- End diff --
    
    Originally, for some reason this is comparing between physicalNames (formatted as "<namespace>:<table>") and the result of getTableName() which is formatted as "<schema>.<table>". However, the format of both values being compared should be "<namespace>:<table>".



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---