Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
From: joshelser <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-236-phoenix@git.apache.org>
In-Reply-To: <git-pr-236-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #236: PHOENIX-3654 Load Balancer for thin client
Content-Type: text/plain
Message-Id: <20170606153918.8E670E04F2@git1-us-west.apache.org>
Date: Tue,  6 Jun 2017 15:39:18 +0000 (UTC)
archived-at: Tue, 06 Jun 2017 15:39:23 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/236#discussion_r120392963
  
    --- Diff: phoenix-queryserver/src/main/java/org/apache/phoenix/loadbalancer/service/PqsZookeeperConfImpl.java ---
    @@ -0,0 +1,97 @@
    +/**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.phoenix.loadbalancer.service;
    +
    +import com.google.common.net.HostAndPort;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hbase.HBaseConfiguration;
    +import org.apache.phoenix.query.QueryServices;
    +import org.apache.phoenix.query.QueryServicesOptions;
    +import org.apache.zookeeper.ZooDefs;
    +import org.apache.zookeeper.data.ACL;
    +import org.apache.zookeeper.data.Id;
    +
    +import java.util.Arrays;
    +import java.util.List;
    +
    +
    +
    +public class PqsZookeeperConfImpl implements PqsZookeeperConf {
    +
    +        private final Configuration configuration;
    +
    +        public PqsZookeeperConfImpl() {
    +           this.configuration = HBaseConfiguration.create();
    +        }
    +
    +        public PqsZookeeperConfImpl(Configuration configuration) {
    +            this.configuration = configuration;
    +        }
    +
    +        @Override
    +        public String getQueryServerBasePath(){
    +            return "/"+configuration.get(QueryServices.PHOENIX_QUERY_SERVER_CLUSTER_BASE_PATH,
    --- End diff --
    
    I think pre-pending the leading '/' is confusing. The user can just provide the full path in ZK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---