phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karan Mehta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3942) Fix failing PhoenixMetricsIT test
Date Thu, 15 Jun 2017 18:35:00 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050920#comment-16050920
] 

Karan Mehta commented on PHOENIX-3942:
--------------------------------------

[~jamestaylor]
HBase 1.1 didn't have {{ServerSideScanMetrics}} class which contains the metrics {{ROWS_SCANNED}}
and {{ROWS_FILTERED}}. It was introduced in 1.2. This is the reason for NPE when accessing
those metrics from the {{ScanMetrics}} map returned by the server. 
The fix would be as follows
{code}
-    static final String COUNT_OF_ROWS_FILTERED_KEY_METRIC_NAME = "ROWS_FILTERED";
-    static final String GLOBAL_BYTES_IN_RESULTS_METRIC_NAME = "BYTES_IN_RESULTS";
-    scanMetricsHolder.getCountOfRowsScanned().change(scanMetricsMap.get(COUNT_OF_ROWS_SCANNED_KEY_METRIC_NAME));
-    scanMetricsHolder.getCountOfRowsFiltered().change(scanMetricsMap.get(COUNT_OF_ROWS_FILTERED_KEY_METRIC_NAME));
{code}

Will submit a patch soon for this branch.

> Fix failing PhoenixMetricsIT test
> ---------------------------------
>
>                 Key: PHOENIX-3942
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3942
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Karan Mehta
>
> The PhoenixMetricsIT seems to be consistently failing in setup with the following exception:
> {code}
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.028 s <<<
FAILURE! - in org.apache.phoenix.monitoring.PhoenixMetricsIT
> [ERROR] org.apache.phoenix.monitoring.PhoenixMetricsIT  Time elapsed: 0.025 s  <<<
ERROR!
> org.apache.phoenix.exception.PhoenixIOException: java.lang.NullPointerException
>         at org.apache.phoenix.monitoring.PhoenixMetricsIT.doSetup(PhoenixMetricsIT.java:95)
> Caused by: java.util.concurrent.ExecutionException: java.lang.NullPointerException
>         at org.apache.phoenix.monitoring.PhoenixMetricsIT.doSetup(PhoenixMetricsIT.java:95)
> Caused by: java.lang.NullPointerException
> {code}
> See https://builds.apache.org/job/Phoenix-4.x-HBase-1.1/436/display/redirect?page=changes
for more information.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message