phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-3907) Use LATEST_TIMESTAMP when UPDATE_CACHE_FREQUENCY is not zero
Date Mon, 05 Jun 2017 21:24:04 GMT


James Taylor commented on PHOENIX-3907:

Thanks for the patch, [~tdsilva]. One possible additional consideration is when a query uses
CURRENT_DATE(). We typically piggyback on the timestamp we get back from the server as our
current date so that we don't have to make another RPC. Can you make sure that we preserve
this optimization? You might need to have a member variable in StatementContext that preserves
the current date and then in addition, do what you're doing to have the result timestamp always
be unset.

> ------------------------------------------------------------
>                 Key: PHOENIX-3907
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>         Attachments: PHOENIX-3907.patch
> For non transactional tables, currently with UPDATE_CACHE_FREQUENCY, we'll use LATEST_TIMESTAMP
*most* of the time, until the cached entity expires, in which case we'll use the server timestamp.
This seems a bit strange and inconsistent. Instead (for non transactional tables), we should
always use LATEST_TIMESTAMP if UPDATE_CACHE_FREQUENCY is non zero, with the exception of the
corner case for UPSERT SELECT and DELETE where the same table is being read and written to
(see changes to FromCompiler for PHOENIX-3823).

This message was sent by Atlassian JIRA

View raw message