phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-3907) Use LATEST_TIMESTAMP when UPDATE_CACHE_FREQUENCY is not zero
Date Wed, 07 Jun 2017 21:02:18 GMT


Hadoop QA commented on PHOENIX-3907:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit 65bd849becbe961bf63c1ac1d88f0cc6a4201931.
  ATTACHMENT ID: 12871879

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 50 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 5 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +        MutationPlan plan = compiler.compile(Collections.singletonList(tableRef), emptyCF,
null, null, ts);
+        this.upperBoundTimeStamp = table.getUpdateCacheFrequency()!=0 ? QueryConstants.UNSET_TIMESTAMP
: upperBoundTimeStamp;

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Javadoc warnings:
Console output:

This message is automatically generated.

> ------------------------------------------------------------
>                 Key: PHOENIX-3907
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>             Fix For: 4.11.0
>         Attachments: PHOENIX-3907.patch, PHOENIX-3907-v2.patch, PHOENIX-3907-v3.patch,
> For non transactional tables, currently with UPDATE_CACHE_FREQUENCY, we'll use LATEST_TIMESTAMP
*most* of the time, until the cached entity expires, in which case we'll use the server timestamp.
This seems a bit strange and inconsistent. Instead (for non transactional tables), we should
always use LATEST_TIMESTAMP if UPDATE_CACHE_FREQUENCY is non zero, with the exception of the
corner case for UPSERT SELECT and DELETE where the same table is being read and written to
(see changes to FromCompiler for PHOENIX-3823).

This message was sent by Atlassian JIRA

View raw message