phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3907) Use LATEST_TIMESTAMP when UPDATE_CACHE_FREQUENCY is not zero
Date Tue, 06 Jun 2017 20:51:18 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039604#comment-16039604
] 

James Taylor commented on PHOENIX-3907:
---------------------------------------

That seems reasonable, [~tdsilva]. Any holes with the upsert select or delete case where we
need the time stamp set? Or if SCN is set? Would another option be to add a currentTime member
variable to TableRef and capture the timestamp from the result there? I think you could the
PTable there to check the updateCacheFrequency value.

> Use LATEST_TIMESTAMP when UPDATE_CACHE_FREQUENCY is not zero
> ------------------------------------------------------------
>
>                 Key: PHOENIX-3907
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3907
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>         Attachments: PHOENIX-3907.patch
>
>
> For non transactional tables, currently with UPDATE_CACHE_FREQUENCY, we'll use LATEST_TIMESTAMP
*most* of the time, until the cached entity expires, in which case we'll use the server timestamp.
This seems a bit strange and inconsistent. Instead (for non transactional tables), we should
always use LATEST_TIMESTAMP if UPDATE_CACHE_FREQUENCY is non zero, with the exception of the
corner case for UPSERT SELECT and DELETE where the same table is being read and written to
(see changes to FromCompiler for PHOENIX-3823).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message