phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karan Mehta (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PHOENIX-3896) Fix test failures related to tracing changes
Date Fri, 02 Jun 2017 00:41:04 GMT

     [ https://issues.apache.org/jira/browse/PHOENIX-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Karan Mehta updated PHOENIX-3896:
---------------------------------
    Attachment: PHOENIX-3896.002.patch

Since we are using separate {{TraceSpanReceiver}} for each test, I moved the production {{TraceSpanReceiver}}
inside the condition which checks if Tracing is turned on or not, which essentially means
that now for each test we have only 1 {{TraceSpanReceiver}}.  The code change looks something
like this. 
{code}
-            if (!initialized) {
+            if (!initialized && QueryServicesOptions.withDefaults().isTracingEnabled())
{
                 traceSpanReceiver = new TraceSpanReceiver();
                 Trace.addReceiver(traceSpanReceiver);
-                if(QueryServicesOptions.withDefaults().isTracingEnabled()) {
-                    QueryServicesOptions options = QueryServicesOptions.withDefaults();
-                    new TraceWriter(options.getTableName(), options.getTracingThreadPoolSize(),
options.getTracingBatchSize());
-                }
+                QueryServicesOptions options = QueryServicesOptions.withDefaults();
+                TraceWriter traceWriter = new TraceWriter(options.getTableName(), options.getTracingThreadPoolSize(),
options.getTracingBatchSize());
+                traceWriter.start();
             }
{code}

> Fix test failures related to tracing changes
> --------------------------------------------
>
>                 Key: PHOENIX-3896
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3896
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Karan Mehta
>         Attachments: PHOENIX-3896.001.patch, PHOENIX-3896.002.patch
>
>
> Looks like our unit tests are breaking after these commits:
> - PHOENIX-3248 Enable HBase server-side scan metrics to be returned to client and surfaced
through metrics
> - PHOENIX-3752 Remove hadoop metrics integration from the tracing framework
> For example, see https://builds.apache.org/job/Phoenix-master/1628/ and https://builds.apache.org/job/Phoenix-4.x-HBase-1.1/405/.
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message