phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-3817) VerifyReplication using SQL
Date Tue, 13 Jun 2017 02:31:01 GMT


Hadoop QA commented on PHOENIX-3817:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against master branch at commit 4196c64b9d29827d0208cd47de6f95697a63c372.
  ATTACHMENT ID: 12872785

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 49 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
    +    public RecordReader<NullWritable,T> createRecordReader(InputSplit split, TaskAttemptContext
+        final Class<T> inputClass = (Class<T>) PhoenixConfigurationUtil.getInputClass(configuration);
+    public List<InputSplit> getSplits(JobContext context) throws IOException, InterruptedException
+    private List<InputSplit> generateSplits(final QueryPlan qplan, final List<KeyRange>
splits, Configuration config) throws IOException {
+        org.apache.hadoop.hbase.client.Connection connection = ConnectionFactory.createConnection(config);
+                    psplits.add(new PhoenixInputSplit(Collections.singletonList(aScan), regionSize,
+            final String currentScnValue = configuration.get(PhoenixConfigurationUtil.CURRENT_SCN_VALUE);
+            final Connection connection = ConnectionUtil.getInputConnection(configuration,
+            final String selectStatement = PhoenixConfigurationUtil.getSelectStatement(configuration);
+            // since we can't set a scn on connections with txn set TX_SCN attribute so that
the max time range is set by BaseScannerRegionObserver 

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results:
Release audit warnings:
Javadoc warnings:
Console output:

This message is automatically generated.

> VerifyReplication using SQL
> ---------------------------
>                 Key: PHOENIX-3817
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Alex Araujo
>            Assignee: Alex Araujo
>            Priority: Minor
>         Attachments: PHOENIX-3817.v1.patch, PHOENIX-3817.v2.patch, PHOENIX-3817.v3.patch
> Certain use cases may copy or replicate a subset of a table to a different table or cluster.
For example, application topologies may map data for specific tenants to different peer clusters.
> It would be useful to have a Phoenix VerifyReplication tool that accepts an SQL query,
a target table, and an optional target cluster. The tool would compare data returned by the
query on the different tables and update various result counters (similar to HBase's VerifyReplication).

This message was sent by Atlassian JIRA

View raw message