phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Loknath Priyatham Teja Singamsetty (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-3773) Implement FIRST_VALUES aggregate function
Date Tue, 06 Jun 2017 11:34:18 GMT


Loknath Priyatham Teja Singamsetty  commented on PHOENIX-3773:

[~tdsilva] [~samarthjain] [~jamestaylor] 
Have incorporated the review comments.

a) Added ability to PArrayDataType.appendItemToArray to build array with element provided
when empty
b) Renamed the variable to isArrayReturnType.
c) Removed the outer loop
d) For nth value return empty byte array with return value as true when not found

Issue with pre-commit build. The master patch file is applied properly. But the pre-commit
build fails applying the 4.x-HBase-0.98 patch although it applies perfectly fine with "git
apply <filename>" on checked out phoenix code. No insight into why this patch failed.
Here are the log lines from the build output:

+ /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/dev/ /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/patchprocess/patch
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/dev/ line 488:
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/dev/ No
such file or directory
+ [[ 127 != 0 ]]

Can you guys help here?


> Implement FIRST_VALUES aggregate function
> -----------------------------------------
>                 Key: PHOENIX-3773
>                 URL:
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: James Taylor
>            Assignee: Loknath Priyatham Teja Singamsetty 
>              Labels: SFDC
>             Fix For: 4.11.0
>         Attachments: PHOENIX-3773_4.x-HBase-0.98_final.patch, PHOENIX-3773_4.x-HBase-0.98.patch,
PHOENIX-3773_master_final.patch, PHOENIX-3773_master.patch, PHOENIX-3773.patch, PHOENIX-3773.v2.patch,
> Similar to FIRST_VALUE, but would allow the user to specify how many values to keep.
This could use a MinMaxPriorityQueue under the covers and be much more efficient than using
multiple NTH_VALUE calls to do the same like this:
> {code}
> SELECT entity_id,
>        NTH_VALUE(user_id,1) WITHIN GROUP (ORDER BY last_read_date DESC) as nth1_user_id,
>        NTH_VALUE(user_id,2) WITHIN GROUP (ORDER BY last_read_date DESC) as nth2_user_id,
>        NTH_VALUE(user_id,3) WITHIN GROUP (ORDER BY last_read_date DESC) as nth3_user_id,
>        count(*)
> WHERE tenant_id='00Dx0000000XXXX'
> AND entity_id in ('0D5x000000ABCD','0D5x000000ABCE')
> GROUP BY entity_id;
> {code}

This message was sent by Atlassian JIRA

View raw message