phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brfrn169 <...@git.apache.org>
Subject [GitHub] phoenix pull request #261: PHOENIX-3944 ReadOnlyTableException occurs when w...
Date Mon, 26 Jun 2017 08:47:19 GMT
Github user brfrn169 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/261#discussion_r123956939
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
    @@ -184,9 +184,9 @@ public static ColumnResolver getResolverForCreation(final CreateTableStatement
s
                 // A tenant-specific connection may not create a mapped VIEW.
                 if (connection.getTenantId() == null && statement.getTableType()
== PTableType.VIEW) {
                     ConnectionQueryServices services = connection.getQueryServices();
    -                byte[] fullTableName = SchemaUtil.getPhysicalName(
    -                        SchemaUtil.getTableNameAsBytes(baseTable.getSchemaName(), baseTable.getTableName()),
    -                        connection.getQueryServices().getProps()).getName();
    +                boolean isNamespaceMapped = SchemaUtil.isNamespaceMappingEnabled(statement.getTableType(),
connection.getQueryServices().getProps());
    +                byte[] fullTableName = SchemaUtil.getPhysicalHBaseTableName(
    --- End diff --
    
    As @ankitsinghal mentioned in the previous comment, I have changed this to handle "AAA.BBB"(without
schema) correctly using SchemaUtil.getPhysicalHBaseTableName() (which I've further modified
in this commit).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message