phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ankitsinghal <...@git.apache.org>
Subject [GitHub] phoenix pull request #261: PHOENIX-3944 ReadOnlyTableException occurs when w...
Date Wed, 21 Jun 2017 05:02:47 GMT
Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/261#discussion_r123154068
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java ---
    @@ -196,7 +196,8 @@ public static ColumnResolver getResolverForCreation(final CreateTableStatement
s
                         if (htable != null) Closeables.closeQuietly(htable);
                     }
                     tableNode = NamedTableNode.create(null, baseTable, statement.getColumnDefs());
    -                return new SingleTableColumnResolver(connection, tableNode, e.getTimeStamp(),
new HashMap<String, UDFParseNode>(1), false);
    +                boolean isNamespaceMapped = SchemaUtil.isNamespaceMappingEnabled(statement.getTableType(),
connection.getQueryServices().getProps());
    --- End diff --
    
    
    To handle view mapped \"NS.TBL\"(without schema)
    
    ```
    -                byte[] fullTableName = SchemaUtil.getPhysicalName(
    -                        SchemaUtil.getTableNameAsBytes(baseTable.getSchemaName(), baseTable.getTableName()),
    -                        connection.getQueryServices().getProps()).getName();
    +                byte[] fullTableName = SchemaUtil
    +                        .getPhysicalName(Bytes.toBytes(baseTable.toString()),
    +                                connection.getQueryServices().getProps())
    +                        .getName();
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message