Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Wed, 17 May 2017 03:04:04 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13071714.1494640228000.227170.1494990244244@Atlassian.JIRA>
In-Reply-To: <JIRA.13071714.1494640228000@Atlassian.JIRA>
References: <JIRA.13071714.1494640228000@Atlassian.JIRA> <JIRA.13071714.1494640228603@jira-lw-us.apache.org>
Subject: [jira] [Commented] (PHOENIX-3850) Indexer.postOpen should not
 always log "Found some outstanding index updates that didn't succeed"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 17 May 2017 03:04:11 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013449#comment-16013449 ] 

Hadoop QA commented on PHOENIX-3850:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12868451/PHOENIX-3850_v2.patch
  against master branch at commit 1666e932d157be732946e02b474b6c342199bc0f.
  ATTACHMENT ID: 12868451

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 47 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/872//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/872//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/872//console

This message is automatically generated.

> Indexer.postOpen should not always log "Found some outstanding index updates that didn't succeed"
> -------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3850
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3850
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.10.0
>            Reporter: chenglei
>            Priority: Minor
>         Attachments: PHOENIX-3850_v2.patch
>
>
> When the RegionServer starts, I always find the region logs "Found some outstanding index updates that didn't succeed during WAL replay - attempting to replay now." That is because in following Indexer.postOpen method, the LOG.info in line 528 is before the if statement in line 531, so the method always log "Found some outstanding index updates that didn't succeed..." no matter whether there are outstanding index updates.
>  {code}
> 520  @Override
> 521  public void postOpen(final ObserverContext<RegionCoprocessorEnvironment> c) {
> 522    Multimap<HTableInterfaceReference, Mutation> updates = failedIndexEdits.getEdits(c.getEnvironment().getRegion());
> 523    
> 524    if (this.disabled) {
> 525        super.postOpen(c);
> 526        return;
> 527      }
> 528   LOG.info("Found some outstanding index updates that didn't succeed during"
> 529        + " WAL replay - attempting to replay now.");
> 530    //if we have no pending edits to complete, then we are done
> 531    if (updates == null || updates.size() == 0) {
> 532      return;
> 533    }
> 534    
> 535    // do the usual writer stuff, killing the server again, if we can't manage to make the index
> 536    // writes succeed again
> 537    try {
> 538        writer.writeAndKillYourselfOnFailure(updates, true);
> 539    } catch (IOException e) {
> 540            LOG.error("During WAL replay of outstanding index updates, "
> 541                    + "Exception is thrown instead of killing server during index writing", e);
> 542    }
> 543  }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)