Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Fri, 19 May 2017 22:02:04 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13069691.1494079309000.253758.1495231324201@Atlassian.JIRA>
In-Reply-To: <JIRA.13069691.1494079309000@Atlassian.JIRA>
References: <JIRA.13069691.1494079309000@Atlassian.JIRA> <JIRA.13069691.1494079309819@jira-lw-us.apache.org>
Subject: [jira] [Commented] (PHOENIX-3834) Provide a way to collect stats
 and not use it for query parallelization
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 19 May 2017 22:02:10 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018093#comment-16018093 ] 

Hadoop QA commented on PHOENIX-3834:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12869061/PHOENIX-3834_v2.patch
  against master branch at commit bd27512666904a727adcd71b13725b02e655902b.
  ATTACHMENT ID: 12869061

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 12 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 47 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +     * @return estimated number of rows that will be scanned when this statement plan is been executed.
+     * @return estimated number of bytes that will be scanned when this statement plan is been executed.
+            ParallelIteratorFactory parallelIteratorFactory, GroupBy groupBy, Expression having) throws SQLException {
+        ExplainPlan exp = plan instanceof BaseQueryPlan ? new ExplainPlan(getPlanSteps(plan.iterator())) : plan.getExplainPlan();
+            QueryPlan plan, HashJoinInfo joinInfo, SubPlan[] subPlans, boolean recompileWhereClause, List<SQLCloseable> dependencies) throws SQLException {
+            Integer limit, Integer offset, OrderBy orderBy, ParallelIteratorFactory parallelIteratorFactory) throws SQLException {
+            Integer limit, Integer offset, OrderBy orderBy, ParallelIteratorFactory parallelIteratorFactory) throws SQLException {
+        Pair<Long, Long> estimate = getEstimateOfDataSizeToScanIfWithinThreshold(context, table.getTable(), perScanLimit);
+    private static Pair<Long, Long> getEstimateOfDataSizeToScanIfWithinThreshold(StatementContext context, PTable table, Integer perScanLimit) throws SQLException {
+        return (perScanLimit * estRowSize < threshold) ? new Pair<>(estimatedBytes, estimatedRows) : null;

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/884//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/884//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/884//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/884//console

This message is automatically generated.

> Provide a way to collect stats and not use it for query parallelization
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-3834
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3834
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-3834.patch, PHOENIX-3834.patch, PHOENIX-3834_v2.patch
>
>


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)