Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Mon, 1 May 2017 14:47:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13041542.1486599288000.91445.1493650024864@Atlassian.JIRA>
In-Reply-To: <JIRA.13041542.1486599288000@Atlassian.JIRA>
References: <JIRA.13041542.1486599288000@Atlassian.JIRA> <JIRA.13041542.1486599288591@jira-lw-us.apache.org>
Subject: [jira] [Commented] (PHOENIX-3655) Metrics for PQS
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 01 May 2017 14:47:11 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990888#comment-15990888 ] 

ASF GitHub Bot commented on PHOENIX-3655:
-----------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/242#discussion_r114132061
  
    --- Diff: phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/metrics/PqsMetricsSystem.java ---
    @@ -0,0 +1,82 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.phoenix.queryserver.metrics;
    +
    +
    +import org.apache.phoenix.queryserver.metrics.sink.PqsFileSink;
    +import org.apache.phoenix.queryserver.metrics.sink.PqsSink;
    +import org.apache.phoenix.queryserver.metrics.sink.PqsSlf4jSink;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +
    +public class PqsMetricsSystem {
    +
    +    public final static String statementLevelMetrics = "statement";
    +    public final static String connectionMetrics = "connection";
    +    protected static final Logger LOG = LoggerFactory.getLogger(PqsMetricsSystem.class);
    +
    +    public Thread getGlobalMetricThread() {
    +        return globalMetricThread;
    +    }
    +
    +    private Thread globalMetricThread = null;
    +    public PqsSink pqsSink;
    +
    +
    +    public PqsMetricsSystem(){
    +
    +        PqsGlobalMetrics pqsGlobalMetricsToJMX = null;
    +        try {
    +            pqsSink = getSinkObject();
    +            pqsGlobalMetricsToJMX = new PqsGlobalMetrics(pqsSink);
    +            globalMetricThread = new Thread(pqsGlobalMetricsToJMX);
    --- End diff --
    
    Should set an uncaught exception handler on this thread.


> Metrics for PQS
> ---------------
>
>                 Key: PHOENIX-3655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3655
>             Project: Phoenix
>          Issue Type: New Feature
>    Affects Versions: 4.8.0
>         Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
>            Reporter: Rahul Shrivastava
>            Assignee: Rahul Shrivastava
>             Fix For: 4.9.0
>
>         Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client. Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need capability to collect metrics at PQS level and push the data to external sink i.e. file, JMX , other external custom sources. 
> 2. Besides this global metrics could be periodically collected and pushed to the sink. 
> 2. PQS can be configured to turn on metrics collection and type of collect ( runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml. 
> All metrics definition https://phoenix.apache.org/metrics.html


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)