Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Sat, 20 May 2017 18:48:05 +0000 (UTC)
From: "Josh Elser (JIRA)" <jira@apache.org>
To: dev@phoenix.apache.org
Message-ID: <JIRA.13041542.1486599288000.256302.1495306085014@Atlassian.JIRA>
In-Reply-To: <JIRA.13041542.1486599288000@Atlassian.JIRA>
References: <JIRA.13041542.1486599288000@Atlassian.JIRA> <JIRA.13041542.1486599288591@jira-lw-us.apache.org>
Subject: [jira] [Commented] (PHOENIX-3655) Metrics for PQS
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 20 May 2017 18:48:10 -0000


    [ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018587#comment-16018587 ] 

Josh Elser commented on PHOENIX-3655:
-------------------------------------

Let me try to clear the air here, I think my previous comment was a little too snark-laden which, admittedly, is partially a result of me having a bad few weeks and not taking the time to edit my response a few times before posting.

I have a pretty specific view of what metrics for PQS should look like. These expectations stem from how I want to leverage these metrics, based on a bigger picture (HDFS and HBase metrics). These lead me to pushing you, Rahul, to a specific implementation that would satisfy your goals but also lead towards my big picture.

What I meant to point out earlier is that I am just one voice. I don't consider myself, nor desire to be, held up on some pedestal as an expert in this area. I am just a person with _some_ knowledge and vested interest on the subject. If others in the Phoenix community think that this feature should go in a different direction than I do, great. I am truly not offended by that. I can always build something that scratches my own itch. My comment about having someone take over on reviewing was solely based on that point: if the ideal direction I see is not what others see, I'm not the one to review it because I will just derail the process.

In short, I didn't mean to be offending anyone here with my opinion. As I've previously stated a few times, if there are others who are happy with Rahul's current contribution, great. Please step up and help shepherd the changes in -- I have no desire to fight a veto battle over an implementation I don't think is optimal. I will not be offended. I hope I haven't hurt any feelings with a heavy hand, I only intended to be pragmatic about the situation.

> Metrics for PQS
> ---------------
>
>                 Key: PHOENIX-3655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3655
>             Project: Phoenix
>          Issue Type: New Feature
>    Affects Versions: 4.8.0
>         Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
>            Reporter: Rahul Shrivastava
>            Assignee: Rahul Shrivastava
>             Fix For: 4.9.0
>
>         Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client. Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need capability to collect metrics at PQS level and push the data to external sink i.e. file, JMX , other external custom sources. 
> 2. Besides this global metrics could be periodically collected and pushed to the sink. 
> 2. PQS can be configured to turn on metrics collection and type of collect ( runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml. 
> All metrics definition https://phoenix.apache.org/metrics.html


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)