Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A5C79200C63 for ; Thu, 11 May 2017 21:35:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A44F5160BC7; Thu, 11 May 2017 19:35:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EAE52160BB3 for ; Thu, 11 May 2017 21:35:06 +0200 (CEST) Received: (qmail 16050 invoked by uid 500); 11 May 2017 19:35:06 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 16039 invoked by uid 99); 11 May 2017 19:35:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 May 2017 19:35:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 80FE4C193C for ; Thu, 11 May 2017 19:35:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 9zAUDXhkKej8 for ; Thu, 11 May 2017 19:35:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B9F365FC8A for ; Thu, 11 May 2017 19:35:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4D3EEE01A8 for ; Thu, 11 May 2017 19:35:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1393A21DEB for ; Thu, 11 May 2017 19:35:04 +0000 (UTC) Date: Thu, 11 May 2017 19:35:04 +0000 (UTC) From: "Maddineni Sukumar (JIRA)" To: dev@phoenix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-2885) Set default value for UPDATE_CACHE_FREQUENCY MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 11 May 2017 19:35:07 -0000 [ https://issues.apache.org/jira/browse/PHOENIX-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007053#comment-16007053 ] Maddineni Sukumar commented on PHOENIX-2885: -------------------------------------------- 1. I will look into parameterizing some tests with default update_cache_frequency param. 2. Regarding priority as of now it is something like below. long updateCacheFrequency = defaultValue!=null?defaultValue:0 if(tableProps.updateCacheFrequency!=null) updateCacheFrequency = tableProps.updateCacheFrequency else if (parentTable!=null) updateCacheFrequency = parentTable.updateCacheFrequency So first priority is to current table specific property if exists, if not then we consider parent table property, if parent table does not exists then only we consider global default configured value. If global default value does not exists then it is zero which is default behavior. So it is same as [~jamestaylor] mentioned above, so I am not changing anything there. > Set default value for UPDATE_CACHE_FREQUENCY > -------------------------------------------- > > Key: PHOENIX-2885 > URL: https://issues.apache.org/jira/browse/PHOENIX-2885 > Project: Phoenix > Issue Type: Sub-task > Reporter: James Taylor > Assignee: Maddineni Sukumar > Fix For: 4.11.0 > > Attachments: PHOENIX-2885.4.10-HBase-0.98.patch, PHOENIX-2885.v2.patch > > > We have the ability currently to tell Phoenix how stale we're will to have the metadata through our UPDATE_CACHE_FREQUENCY feature[1]. By default, when a table is created, unless explicitly specified, there is no UPDATE_CACHE_FREQUENCY set. We should provide a new Phoenix configuration parameter to specify a default value when a CREATE TABLE statement is executed. In addition, when a VIEW is created, we should inherit the UPDATE_CACHE_FREQUENCY value from the parent (unless it's explicitly specified) and then fallback to the new default config value. > [1] https://phoenix.apache.org/language/index.html#options -- This message was sent by Atlassian JIRA (v6.3.15#6346)