Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
From: JamesRTaylor <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-239-phoenix@git.apache.org>
In-Reply-To: <git-pr-239-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...
Content-Type: text/plain
Message-Id: <20170515181209.06817DFD43@git1-us-west.apache.org>
Date: Mon, 15 May 2017 18:12:09 +0000 (UTC)
archived-at: Mon, 15 May 2017 18:12:11 -0000

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/239#discussion_r116562096
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricType.java ---
    @@ -25,6 +25,7 @@
         QUERY_TIME("Query times"),
         NUM_PARALLEL_SCANS("Number of scans that were executed in parallel"),
         SCAN_BYTES("Number of bytes read by scans"),
    +    SNAPSHOT_SCAN_BYTES("Number of bytes read by snapshot scans"),
    --- End diff --
    
    Do we need a different metric here? Or would it make more sense to use SCAN_BYTES for the snapshot case too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---