Return-Path: <dev-return-40776-archive-asf-public=cust-asf.ponee.io@phoenix.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id D9267200C67
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 15 May 2017 20:06:27 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id D79AD160BC2; Mon, 15 May 2017 18:06:27 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 20F6C160BA9
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 15 May 2017 20:06:26 +0200 (CEST)
Received: (qmail 4853 invoked by uid 500); 15 May 2017 18:06:26 -0000
Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@phoenix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@phoenix.apache.org>
List-Post: <mailto:dev@phoenix.apache.org>
List-Id: <dev.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list dev@phoenix.apache.org
Received: (qmail 4842 invoked by uid 99); 15 May 2017 18:06:26 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 May 2017 18:06:26 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id E3C95DFD43; Mon, 15 May 2017 18:06:25 +0000 (UTC)
From: JamesRTaylor <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-239-phoenix@git.apache.org>
In-Reply-To: <git-pr-239-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...
Content-Type: text/plain
Message-Id: <20170515180625.E3C95DFD43@git1-us-west.apache.org>
Date: Mon, 15 May 2017 18:06:25 +0000 (UTC)
archived-at: Mon, 15 May 2017 18:06:28 -0000

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/239#discussion_r116560730
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java ---
    @@ -496,6 +496,17 @@ public BaseResultIterators(QueryPlan plan, Integer perScanLimit, Integer offset,
                 return scans;
         }
     
    +    private List<HRegionLocation> getRegionBoundaries(ParallelScanGrouper scanGrouper)
    +        throws SQLException{
    +        if (scanGrouper instanceof DefaultParallelScanGrouper) {
    --- End diff --
    
    These casts should not be necessary. Either add an init method to ParallelScanGrouper or call the init from the implementing class in getRegionBoundaries.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---