phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3773) Implement FIRST_VALUES aggregate function
Date Wed, 31 May 2017 07:52:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030796#comment-16030796
] 

Hadoop QA commented on PHOENIX-3773:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12870525/PHOENIX-3733_master.patch
  against master branch at commit e3fc929e93715a359b4267db9f4d12706247a6a6.
  ATTACHMENT ID: 12870525

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

		    {color:red}-1 Anti-pattern{color}.  The patch appears to have anti-pattern where BYTES_COMPARATOR
was omitted:
                  protected TreeMap<byte[], LinkedList<byte[]>> topValues = new
TreeMap<byte[], LinkedList<byte[]>>(new ByteArrayComparator());.

                    {color:red}-1 Known Incompatible class{color}.  The patch appears to have
 incompatible classes:
                  protected TreeMap<byte[], LinkedList<byte[]>> topValues = new
TreeMap<byte[], LinkedList<byte[]>>(new ByteArrayComparator());.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 45 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +            "UPSERT INTO " + table_name + " (id, page_id, \"DATE\", \"value\") VALUES
(1, 8, '1', '3')");
+            "UPSERT INTO " + table_name + " (id, page_id, \"DATE\", \"value\") VALUES (2,
8, '2', '7')");
+            "UPSERT INTO " + table_name + " (id, page_id, \"DATE\", \"value\") VALUES (3,
8, '3', '9')");
+            "UPSERT INTO " + table_name + " (id, page_id, \"DATE\", \"value\") VALUES (5,
8, '4', '2')");
+            "UPSERT INTO " + table_name + " (id, page_id, \"DATE\", \"value\") VALUES (4,
8, '5', '4')");
+            "SELECT FIRST_VALUES(\"value\", 2) WITHIN GROUP (ORDER BY \"DATE\" ASC) FROM
" + table_name
+            "UPSERT INTO " + tableName + " (id, page_id, \"DATE\", \"value\") VALUES (1,
8, 1, 300)");
+            "UPSERT INTO " + tableName + " (id, page_id, \"DATE\", \"value\") VALUES (4,
8, 5, 400)");
+            "SELECT FIRST_VALUES(\"value\", 2) WITHIN GROUP (ORDER BY \"DATE\" ASC) FROM
" + tableName
+            "UPSERT INTO " + tableName + " (id, page_id, \"DATE\", \"value\") VALUES (1,
8, 1, 300)");

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SpillableGroupByIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/938//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/938//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/938//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/938//console

This message is automatically generated.

> Implement FIRST_VALUES aggregate function
> -----------------------------------------
>
>                 Key: PHOENIX-3773
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3773
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: James Taylor
>            Assignee: Loknath Priyatham Teja Singamsetty 
>              Labels: SFDC
>             Fix For: 4.11.0
>
>         Attachments: PHOENIX-3773_4.x-HBase-0.98.patch, PHOENIX-3773_master.patch, PHOENIX-3773.patch,
PHOENIX-3773.v2.patch, PHOENIX-3773.v3.patch
>
>
> Similar to FIRST_VALUE, but would allow the user to specify how many values to keep.
This could use a MinMaxPriorityQueue under the covers and be much more efficient than using
multiple NTH_VALUE calls to do the same like this:
> {code}
> SELECT entity_id,
>        NTH_VALUE(user_id,1) WITHIN GROUP (ORDER BY last_read_date DESC) as nth1_user_id,
>        NTH_VALUE(user_id,2) WITHIN GROUP (ORDER BY last_read_date DESC) as nth2_user_id,
>        NTH_VALUE(user_id,3) WITHIN GROUP (ORDER BY last_read_date DESC) as nth3_user_id,
>        count(*)
> FROM  MY_TABLE 
> WHERE tenant_id='00Dx0000000XXXX'
> AND entity_id in ('0D5x000000ABCD','0D5x000000ABCE')
> GROUP BY entity_id;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message