phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Loknath Priyatham Teja Singamsetty (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3773) Implement FIRST_VALUES aggregate function
Date Wed, 31 May 2017 04:18:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030608#comment-16030608
] 

Loknath Priyatham Teja Singamsetty  commented on PHOENIX-3773:
--------------------------------------------------------------

[~jamestaylor] [~samarthjain]

Here is what i'm doing to create patch which is working for master and 4.x branch locally.
This used to work earlier but the precommit build is failing now while applying to master.

a) checkout to 4.x-HBase-0.98
b) git commit
c) git format-patch HEAD -1

I have also tried the instructions specified in http://phoenix.apache.org/contributing.html.
This is resulting in patch file with lot of commits back dated from 2014 when i run "git format-patch
--stdout origin > PHOENIX-{NUMBER}.patch"

Between on debugging further from build console output, 

{quote}
+ /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/dev/smart-apply-patch.sh /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/patchprocess/patch
The patch does not appear to apply with p0 to p2
+ [[ 1 != 0 ]]
+ echo 'PATCH APPLICATION FAILED'
PATCH APPLICATION FAILED
+ JIRA_COMMENT='Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12870496/PHOENIX-3733.v4.patch
  against master branch at commit e3fc929e93715a359b4267db9f4d12706247a6a6.
{quote}

Would like to know the commands part of smart-apply-patch.sh for further debugging.


> Implement FIRST_VALUES aggregate function
> -----------------------------------------
>
>                 Key: PHOENIX-3773
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3773
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: James Taylor
>            Assignee: Loknath Priyatham Teja Singamsetty 
>              Labels: SFDC
>             Fix For: 4.11.0
>
>         Attachments: PHOENIX-3733.v4.patch, PHOENIX-3773.patch, PHOENIX-3773.v2.patch,
PHOENIX-3773.v3.patch
>
>
> Similar to FIRST_VALUE, but would allow the user to specify how many values to keep.
This could use a MinMaxPriorityQueue under the covers and be much more efficient than using
multiple NTH_VALUE calls to do the same like this:
> {code}
> SELECT entity_id,
>        NTH_VALUE(user_id,1) WITHIN GROUP (ORDER BY last_read_date DESC) as nth1_user_id,
>        NTH_VALUE(user_id,2) WITHIN GROUP (ORDER BY last_read_date DESC) as nth2_user_id,
>        NTH_VALUE(user_id,3) WITHIN GROUP (ORDER BY last_read_date DESC) as nth3_user_id,
>        count(*)
> FROM  MY_TABLE 
> WHERE tenant_id='00Dx0000000XXXX'
> AND entity_id in ('0D5x000000ABCD','0D5x000000ABCE')
> GROUP BY entity_id;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message