phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3734) Refactor Phoenix to use TAL instead of direct calls to Tephra
Date Mon, 15 May 2017 09:36:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010236#comment-16010236
] 

Hadoop QA commented on PHOENIX-3734:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12867987/PHOENIX-3734.v3.patch
  against master branch at commit 442d8eb29f1f73fd104a323d9aa77f3a4ccfd8d1.
  ATTACHMENT ID: 12867987

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 47 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +	            optionBuilder.append(",IMMUTABLE_STORAGE_SCHEME="+PTableImpl.ImmutableStorageScheme.ONE_CELL_PER_COLUMN);
+                { false, false, false }, { false, false, true }, { false, true, false },
{ false, true, true },
+                { true, false, false }, { true, false, true }, { true, true, false }, { true,
true, true }
+        conn.createStatement().execute("CREATE TABLE " + fullTableName + "(pk INTEGER PRIMARY
KEY, val INTEGER)"+tableDDLOptions);
+            stmt.execute("CREATE TABLE " + fullTableName + "(k VARCHAR PRIMARY KEY, v1 VARCHAR,
v2 VARCHAR)"+tableDDLOptions);
+			stmt.execute("CREATE TABLE " + fullTableName + "(ID BIGINT NOT NULL PRIMARY KEY, v1 VARCHAR,
v2 VARCHAR)"
+			stmt.execute("CREATE TABLE " + fullTableName + "1(ID1 BIGINT NOT NULL PRIMARY KEY, FK1A
INTEGER, FK1B INTEGER)"
+            assertEquals(PhoenixVisibilityLevel.SNAPSHOT_EXCLUDE_CURRENT, state.getVisibilityLevel());
+                dataRegion, indexMaintainer, viewConstants, null, null, projector, ptr, useQualiferAsListIndex);
+                            delete.setAttribute(PhoenixTransactionContext.TX_ROLLBACK_ATTRIBUTE_KEY,
new byte[0]);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryDatabaseMetaDataIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.iterate.ScannerLeaseRenewalIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/865//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/865//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/865//console

This message is automatically generated.

> Refactor Phoenix to use TAL instead of direct calls to Tephra
> -------------------------------------------------------------
>
>                 Key: PHOENIX-3734
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3734
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Ohad Shacham
>            Assignee: Ohad Shacham
>         Attachments: PHOENIX-3734.v3.patch
>
>
> Refactor Phoenix to use the new transaction abstraction layer instead of direct calls
to Tephra. Once this task will be committed, Phoenix will continue working with Tephra but
will have the option for fast integration of new transaction processing engines.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message