phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3655) Metrics for PQS
Date Tue, 16 May 2017 22:08:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013181#comment-16013181
] 

ASF GitHub Bot commented on PHOENIX-3655:
-----------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/242#discussion_r116868081
  
    --- Diff: phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/server/PhoenixMetaFactoryImpl.java
---
    @@ -68,7 +73,18 @@ public Meta create(List<String> args) {
                 "0 or 1 argument expected. Received " + Arrays.toString(args.toArray()));
           }
           // TODO: what about -D configs passed in from cli? How do they get pushed down?
    -      return new JdbcMeta(url, info);
    +      boolean isMetricOn = conf.getBoolean(PHOENIX_QUERY_SERVER_METRICS,
    +              DEFAULT_PHOENIX_QUERY_SERVER_METRICS);
    +      if (isMetricOn) {
    +        info.put("pqs_reporting_interval", PqsMetricsSystem.getReportingInterval(conf));
    --- End diff --
    
    Why this indirection with pqs_reporting_interval to phoenix.query.server.metrics.report.interval.ms
internally? Just use our configuration properties all around.


> Metrics for PQS
> ---------------
>
>                 Key: PHOENIX-3655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3655
>             Project: Phoenix
>          Issue Type: New Feature
>    Affects Versions: 4.8.0
>         Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
>            Reporter: Rahul Shrivastava
>            Assignee: Rahul Shrivastava
>             Fix For: 4.9.0
>
>         Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client. Metrics collection
is currently done by PhoenixRuntime.java i.e. at Phoenix driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need capability to collect
metrics at PQS level and push the data to external sink i.e. file, JMX , other external custom
sources. 
> 2. Besides this global metrics could be periodically collected and pushed to the sink.

> 2. PQS can be configured to turn on metrics collection and type of collect ( runtime
or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml. 
> All metrics definition https://phoenix.apache.org/metrics.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message