phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-3655) Metrics for PQS
Date Fri, 12 May 2017 21:58:04 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008775#comment-16008775
] 

ASF GitHub Bot commented on PHOENIX-3655:
-----------------------------------------

Github user rahulsIOT commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/242#discussion_r116331710
  
    --- Diff: phoenix-queryserver/src/main/java/org/apache/phoenix/queryserver/metrics/PqsGlobalMetrics.java
---
    @@ -0,0 +1,76 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.phoenix.queryserver.metrics;
    +
    +
    +import com.codahale.metrics.Gauge;
    +import com.codahale.metrics.MetricRegistry;
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.phoenix.monitoring.GlobalMetric;
    +import org.apache.phoenix.queryserver.metrics.sink.PqsSink;
    +import org.apache.phoenix.util.PhoenixRuntime;
    +
    +import java.util.Collection;
    +
    +public class PqsGlobalMetrics implements Runnable {
    +
    +    protected static final Log LOG = LogFactory.getLog(PqsGlobalMetrics.class);
    +    public final static String global = "global";
    +    private Collection<GlobalMetric> phoenixGlobalMetricsCollection;
    +    private PqsSink pqsSink;
    +    private static final MetricRegistry metrics = new MetricRegistry();
    +
    +    public PqsGlobalMetrics(PqsSink pqsSink) {
    +        phoenixGlobalMetricsCollection = PhoenixRuntime.getGlobalPhoenixClientMetrics();
    +        this.pqsSink = pqsSink;
    +        for(final GlobalMetric globalMetric:phoenixGlobalMetricsCollection) {
    +            metrics.register(MetricRegistry.name(PqsGlobalMetrics.class,
    +                    global,globalMetric.getName()),
    +                    new Gauge<Long>() {
    +                        @Override
    +                        public Long getValue() {
    +                            return globalMetric.getValue();
    +                        }
    +                    });
    +        }
    +
    +    }
    +
    +    @Override
    +    public void run() {
    +        while (true) {
    +            int delay = PqsConfiguration.getReportingInterval();
    +            //besides writing to JMX, the global metrics is also written to pqsSink
    +            //default pqsSink is slf4j ( logger)
    +            phoenixGlobalMetricsCollection = PhoenixRuntime.getGlobalPhoenixClientMetrics();
    +            this.pqsSink.writeGlobal(phoenixGlobalMetricsCollection);
    +            try {
    +                Thread.sleep(delay);
    +            } catch (InterruptedException e) {
    +                LOG.error(" Sleep thread interrupted for metrics collection ");
    --- End diff --
    
    agreed. 


> Metrics for PQS
> ---------------
>
>                 Key: PHOENIX-3655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3655
>             Project: Phoenix
>          Issue Type: New Feature
>    Affects Versions: 4.8.0
>         Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
>            Reporter: Rahul Shrivastava
>            Assignee: Rahul Shrivastava
>             Fix For: 4.9.0
>
>         Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
>   Original Estimate: 240h
>  Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client. Metrics collection
is currently done by PhoenixRuntime.java i.e. at Phoenix driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need capability to collect
metrics at PQS level and push the data to external sink i.e. file, JMX , other external custom
sources. 
> 2. Besides this global metrics could be periodically collected and pushed to the sink.

> 2. PQS can be configured to turn on metrics collection and type of collect ( runtime
or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml. 
> All metrics definition https://phoenix.apache.org/metrics.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message